Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add themed icon #499

Closed
wants to merge 1 commit into from
Closed

Add themed icon #499

wants to merge 1 commit into from

Conversation

M3DZIK
Copy link

@M3DZIK M3DZIK commented Aug 22, 2023 •
edited
Loading

closes #498

@M3DZIK
Add themed icon
bee473c 
Signed-off-by: M3DZIK <[email protected]>
@przemyslawzygmunt
Copy link
Member

Contributor License Agreement is not signed yet.

@M3DZIK
Copy link
Author

M3DZIK commented Aug 23, 2023

Contributor License Agreement is not signed yet.

?

@przemyslawzygmunt
Copy link
Member

You must accept the CLA license in order for us to accept this pull request. You can find a link to it under "Some checks haven't completed yet"

@M3DZIK
Copy link
Author

M3DZIK commented Aug 23, 2023 •
edited
Loading

You must accept the CLA license in order for us to accept this pull request. You can find a link to it under "Some checks haven't completed yet"

Why must I?

@przemyslawzygmunt
Copy link
Member

This is a condition for PR to be considered.

@M3DZIK
Copy link
Author

M3DZIK commented Aug 23, 2023

This is a condition for PR to be considered.

Why is it required?

@przemyslawzygmunt
Copy link
Member

We do not include sources that are not regulated by law in the project.

@M3DZIK
Copy link
Author

M3DZIK commented Aug 23, 2023

We do not include sources that are not regulated by law in the project.

Because? My changes are on gpl2 so I don't see a problem

@przemyslawzygmunt
Copy link
Member

If the acceptance of the conditions described in the CLA is a problem, this PR will be closed. This is the practice used by many OpenSource projects.

@M3DZIK M3DZIK closed this by deleting the head repository Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add themed icon
2 participants
@M3DZIK @przemyslawzygmunt