Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming UsersModule, QuestionsModule, TopicsModule and GroupsModule #83

Open
Nictheboy opened this issue Mar 11, 2024 · 1 comment
Open
Assignees

Comments

@Nictheboy
Copy link
Contributor

Nictheboy commented Mar 11, 2024

I have to apologize for using names like UsersModule, QuestionsModule and TopicsModule which is not so proper. Maybe we should rename them into UserModule, QuestionModule and TopicModule, together with all the controllers' and services' class name. (GroupsModule is also under this naming convention to be consistent with these names.)

This is very easy to do thanks to VSCode's renaming functionality. However, it need to be done when all PRs are merged. This is the true difficulty :(

It's OK if we just don't fix this :)

@andylizf
Copy link
Contributor

Glad to hear you remembered that the original groups.entity was renamed to groups.legacy sometime ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants