Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error #506

Open
0-Captain opened this issue Sep 3, 2021 · 2 comments · May be fixed by #508
Open

Error #506

0-Captain opened this issue Sep 3, 2021 · 2 comments · May be fixed by #508

Comments

@0-Captain
Copy link

draggable/src/Draggable/Plugins/Mirror/Mirror.js

Line 559 in 6f5539b

{frame: withFrame},

The second param type of withPromise is {raf: boolean}. Is there a wrong usage here？
@0-Captain
Copy link
Author

draggable/src/Draggable/Plugins/Mirror/Mirror.js

Line 365 in 6f5539b

.then(positionMirror({raf: true}))

@zjffun
Copy link
Contributor

zjffun commented Sep 4, 2021

This is indeed a bug. Could you create a PR to fix it? We can wait for the maintainer to have time to merge this fix. Thank you.

0-Captain pushed a commit to 0-Captain/draggable that referenced this issue Sep 7, 2021
fix(plugin:mirror): incorrect use of the function 'positionMirror'
325ab79 
fix Shopify#506
@0-Captain 0-Captain linked a pull request Sep 8, 2021 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugin:mirror): incorrect use of the function 'positionMirror' 0-Captain/draggable
2 participants
@zjffun @0-Captain