From 06e8adb7d29b0530e2fd510ba6de463fe5d93917 Mon Sep 17 00:00:00 2001
From: SilverNexus <a_daniel.hawkins@yahoo.com>
Date: Sun, 10 Feb 2019 09:56:15 -0500
Subject: [PATCH] Improve variable name resolution by making more variables
 local.

---
 train.lua | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/train.lua b/train.lua
index 9bd72887..b6fd5dc3 100644
--- a/train.lua
+++ b/train.lua
@@ -209,7 +209,7 @@ for name,proto in pairs(protos) do
 end
 
 -- preprocessing helper function
-function prepro(x,y)
+local function prepro(x,y)
     x = x:transpose(1,2):contiguous() -- swap the axes for faster indexing
     y = y:transpose(1,2):contiguous()
     if opt.gpuid >= 0 and opt.opencl == 0 then -- ship the input arrays to GPU
@@ -271,12 +271,13 @@ function feval(x)
     local rnn_state = {[0] = init_state_global}
     local predictions = {}           -- softmax outputs
     local loss = 0
+    local local_clones = clones
     for t=1,opt.seq_length do
-        clones.rnn[t]:training() -- make sure we are in correct mode (this is cheap, sets flag)
-        local lst = clones.rnn[t]:forward{x[t], unpack(rnn_state[t-1])}
+        local_clones.rnn[t]:training() -- make sure we are in correct mode (this is cheap, sets flag)
+        local lst = local_clones.rnn[t]:forward{x[t], unpack(rnn_state[t-1])}
         rnn_state[t] = {unpack(lst, i, #init_state)} -- extract the state, without output
         predictions[t] = lst[#lst] -- last element is the prediction
-        loss = loss + clones.criterion[t]:forward(predictions[t], y[t])
+        loss = loss + local_clones.criterion[t]:forward(predictions[t], y[t])
     end
     loss = loss / opt.seq_length
     ------------------ backward pass -------------------
@@ -284,9 +285,9 @@ function feval(x)
     local drnn_state = {[opt.seq_length] = clone_list(init_state, true)} -- true also zeros the clones
     for t=opt.seq_length,1,-1 do
         -- backprop through loss, and softmax/linear
-        local doutput_t = clones.criterion[t]:backward(predictions[t], y[t])
+        local doutput_t = local_clones.criterion[t]:backward(predictions[t], y[t])
         drnn_state[t][#drnn_state[t]+1] = doutput_t
-        local dlst = clones.rnn[t]:backward({x[t], unpack(rnn_state[t-1])}, drnn_state[t])
+        local dlst = local_clones.rnn[t]:backward({x[t], unpack(rnn_state[t-1])}, drnn_state[t])
         -- dlst[1] is the gradient on x, which we don't need
         -- using unpack should slide the values into the correct indexes, allowing us to forego a loop.
         drnn_state[t-1] = {unpack(dlst, 2)}