Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unauthorised admin page accesses should not result in page load #476

Open
maaverik opened this issue Jan 17, 2021 · 4 comments
Open

Unauthorised admin page accesses should not result in page load #476

maaverik opened this issue Jan 17, 2021 · 4 comments
Labels
You Can Do This Will be accepted on priority

Comments

@maaverik
Copy link
Collaborator

Describe the bug
If we try opening the admin page of a queue created by another signed-in user, the page opens, although backend info doesn't come through. We shouldn't even show the admin page in cases like this.

To Reproduce
Steps to reproduce the behavior:
Open the admin link of a queue created by a different signed-in user. The page opens up with options even though the member list doesn't load.

Expected behavior
It should clearly say "unauthorized access, please login to continue" or "you're not the owner of this queue".

@maaverik maaverik added the You Can Do This Will be accepted on priority label Jan 17, 2021
@daltonfury42
Copy link
Collaborator

daltonfury42 commented Jan 19, 2021

One option is to have a "Unauthorised" page like PageNotFound in your routes at path="/unauthorised".

Then whenever we make a network call, if backend returns (401, Unauthorised), we should take the user to the Unauthorised page here.

The only caveat is that the moment some request says unauthorised, the user will be taken to the new page. But I in our current state, this is what we need,

@mathkruger
Copy link
Contributor

@maaverik Can I take this one?

@tusharrajpoot
Copy link

@maaverik can i do this?

@maaverik
Copy link
Collaborator Author

This project is not being actively maintained anymore. Thanks for offering to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
You Can Do This Will be accepted on priority
Projects
None yet
Development

No branches or pull requests

4 participants