Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Expose bhe_saml_sp_key and bhe_saml_sp_cert via ENV variables #954

Closed
Daniel-CS-Team opened this issue Nov 14, 2024 · 3 comments
Closed
Labels
enhancement New feature or request ticketed (automation only) Ticket has been created internally for tracking

Comments

@Daniel-CS-Team
Copy link

Feature Description

Expose bhe_saml_sp_key and bhe_saml_sp_cert via ENV variables, so that they can be managed via docker secrets or AWS SecretsManager or equivalent for other platforms.

Are you intending to implement this feature?

no

Current Behavior

bhe_saml_sp_key and bhe_saml_sp_cert must be set in the config-file. Which means that you have to put a private key in plaintext in a static config file, which might be managed via git. This is considered bad practice (at least in our organization), as secrets should only be available at runtime.

Desired Behavior

bhe_saml_sp_key and bhe_saml_sp_cert can be controlled via ENV variables, so that they can be provided only at container runtime and can be stored via the platforms secrets management facility.

Use Case

The features increases the security of bhe_saml_sp_key, makes management of BH easier and makes BH more compliant with security best practices.

Additional Information

First mentioned in Issue 83.

@Daniel-CS-Team Daniel-CS-Team added enhancement New feature or request triage This issue requires triaging labels Nov 14, 2024
@yannickwellens
Copy link

Any news on this? :)

@XanderVanRompaye1
Copy link

Hi, we are waiting for this feature so we can enable SSO.
Is there an update on this issue?
Thanks in advance!

@StephenHinck StephenHinck added ticketed (automation only) Ticket has been created internally for tracking and removed triage This issue requires triaging labels Jan 6, 2025
@StephenHinck
Copy link
Contributor

Apologies for the delay on this one - this is already supported, please see: https://github.com/SpecterOps/BloodHound/wiki/Using-Environment-Variables-For-Sensitive-Configuration. You may use the variables bhe_saml_sp_cert and bhe_saml_sp_key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ticketed (automation only) Ticket has been created internally for tracking
Projects
None yet
Development

No branches or pull requests

4 participants