Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SafeVarargs where appropriate #13

Open
nickavv opened this issue Apr 9, 2018 · 1 comment
Open

Use SafeVarargs where appropriate #13

nickavv opened this issue Apr 9, 2018 · 1 comment
Labels
enhancement New feature or request release scope: micro Changes required for the issue are appropriate for a semantically "micro" release

Comments

@nickavv
Copy link
Member

nickavv commented Apr 9, 2018

Not sure if we are going to be implementing ImmutableList or its friends in Alloy, but if so we should appropriately annotate any place where we use varargs in a safe with with @SafeVarargs.

See this StackOverflow post:
https://stackoverflow.com/questions/30130262/is-safevarargs-an-appropriate-annotation-for-this-method
@romeara romeara added the enhancement New feature or request label Apr 12, 2018
@romeara romeara added the release scope: micro Changes required for the issue are appropriate for a semantically "micro" release label Jul 30, 2019
@romeara
Copy link
Member

romeara commented Jul 31, 2019

I believe we do this where appropriate, and this sort of general statement in an issue won't help remind us - @nickavv any objections to closing this out and handling this on a case-by-case basis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request release scope: micro Changes required for the issue are appropriate for a semantically "micro" release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romeara @nickavv