This repository has been archived by the owner on Jul 31, 2021. It is now read-only.
Open top-level type documentation for methods. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tvanhens I could do some more work to open a URL with the correct fragment, but have stopped here to make sure the approach makes sense. |
tvanhens
reviewed
Oct 30, 2019
| (with-meta (symbol name) | ||
| {:doc (render-docs docs) | ||
| :arglists (list (vec (cons 'this (mapv (comp symbol :name) parameters))))}) | ||
| (with-meta |
There was a problem hiding this comment.
The metadata should go on the symbol above (which will get put on the var that gets bound) rather than the function.
There was a problem hiding this comment.
I'll make the change.
|
Some upcoming work from @tvanhens will conflict with this change. I'm going to re-open this once that other work lands. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53.