Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timecode beutify enhancement #9144

Open
warrentc3 opened this issue Dec 28, 2024 · 3 comments
Open

timecode beutify enhancement #9144

warrentc3 opened this issue Dec 28, 2024 · 3 comments

Comments

@warrentc3
Copy link

          @niksedk if all that's really needed is pkt_dts_time... could be even more precise on the cmd.

Although, part of me thinks that pts_time or best_effort_timestamp_time might be more fit for purpose.

ffprobe.exe -hide_banner -loglevel warning -err_detect ignore_err -threads 1 -select_streams v -show_optional_fields auto -show_entries frame=pts_time,pkt_dts_time,best_effort_timestamp_time -output_format csv=print_section=0:nokey=1 -i "inputfile"

I'd be curious, in cases of a variance or non-existence of pts||dts stamps, what might be achievable.

The above command spits out something like this...
0.000000,0.000000,0.000000,
0.042000,0.042000,0.042000,
0.083000,0.083000,0.083000,
0.125000,0.125000,0.125000,
0.167000,0.167000,0.167000,
0.209000,0.209000,0.209000,
0.250000,0.250000,0.250000,
0.292000,0.292000,0.292000,
0.334000,0.334000,0.334000,
0.375000,0.375000,0.375000,
0.417000,0.417000,0.417000,
0.459000,0.459000,0.459000,
0.501000,0.501000,0.501000,
0.542000,0.542000,0.542000,

Originally posted by @warrentc3 in #9097 (comment)

@niksedk
Copy link
Member

niksedk commented Dec 28, 2024

What do you mean by this?

@warrentc3
Copy link
Author

After the last change, I realized that -show_frames was part of why the side_data was being displayed. With specifying the requisite entries, that parameter isn't required. There are some edge cases where pts time and dts time are not 1:1, hence the "best_effort_timestamp_time".

At a minimum, should drop the "-show_frames" to mitigate superflous optional fields

@niksedk
Copy link
Member

niksedk commented Dec 28, 2024

So, why the edge cases where pts time and dts time are not 1:1?
Could you test if best_effort_timestamp_time" gives the correct seconds when different from pts time?

Can you make a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants