Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning when interlink-shortcode is not set in guides.xml #827

Open
garvinhicking opened this issue Nov 15, 2024 · 1 comment
Open

Add warning when interlink-shortcode is not set in guides.xml #827

garvinhicking opened this issue Nov 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@garvinhicking
Copy link
Contributor

It seems the Core manuals like cms-form cannot yet properly resolve their interlink inventory key:

https://docs.typo3.org/c/typo3/cms-form/main/en-us/I/Concepts/Configuration/Index.html#concepts-configuration-yamlregistration-backend-addtyposcriptsetup

The RST link is:

Is:
:ref:`YAML registration for the backend via addTypoScriptSetup() <somemanual:concepts-configuration-yamlregistration-backend-addtyposcriptsetup>`

Should be:
:ref:`YAML registration for the backend via addTypoScriptSetup() <typo3/cms-form:concepts-configuration-yamlregistration-backend-addtyposcriptsetup>`

and the permalink:

Is:
https://docs.typo3.org/permalink/somemanual:concepts-configuration-yamlregistration-backend-addtyposcriptsetup

Should be:
https://docs.typo3.org/permalink/typo3-cms-form:concepts-configuration-yamlregistration-backend-addtyposcriptsetup
@garvinhicking garvinhicking added the bug Something isn't working label Nov 15, 2024
@linawolf
Copy link
Member

It seems like :confval:interlink-shortcode <h2document:guides-extension-interlink-shortcode> is not set in the guides.xml form
I think we should throw a warning in such case.

@linawolf linawolf changed the title TYPO3 Core manuals are linked with "somemanual" Add warning when interlink-shortcode is not set in guides.xml Nov 16, 2024
reviewtypo3org pushed a commit to TYPO3/typo3 that referenced this issue Nov 18, 2024
@linawolf @fe-hicking
[DOCS] Fix interlink-shortcodes in EXT:form and EXT:styleguide
76f3865 
EXT:styleguide had a typo in the interlink-shortcode,
and EXT:form was missing an interlink-shortcode.

See also TYPO3-Documentation/render-guides#827

Other guides.xml in system extensions were checked and
seem proper.

Resolves: #105611
Releases: main, 13.4, 12.4
Change-Id: I9a78db529e69b46588923a3d764f7d83f6e1cc16
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87002
Reviewed-by: Chris Müller <[email protected]>
Tested-by: Garvin Hicking <[email protected]>
Reviewed-by: Benni Mack <[email protected]>
Reviewed-by: Garvin Hicking <[email protected]>
Tested-by: core-ci <[email protected]>
reviewtypo3org pushed a commit to TYPO3/typo3 that referenced this issue Nov 18, 2024
@linawolf @fe-hicking
[DOCS] Fix interlink-shortcodes in EXT:form and EXT:styleguide
dec23c9 
EXT:styleguide had a typo in the interlink-shortcode,
and EXT:form was missing an interlink-shortcode.

See also TYPO3-Documentation/render-guides#827

Other guides.xml in system extensions were checked and
seem proper.

Resolves: #105611
Releases: main, 13.4, 12.4
Change-Id: I9a78db529e69b46588923a3d764f7d83f6e1cc16
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87016
Tested-by: core-ci <[email protected]>
Tested-by: Garvin Hicking <[email protected]>
Reviewed-by: Garvin Hicking <[email protected]>
reviewtypo3org pushed a commit to TYPO3/typo3 that referenced this issue Nov 18, 2024
@linawolf @fe-hicking
[DOCS] Fix interlink-shortcodes in EXT:form and EXT:styleguide
dc39c8d 
EXT:styleguide had a typo in the interlink-shortcode,
and EXT:form was missing an interlink-shortcode.

See also TYPO3-Documentation/render-guides#827

Other guides.xml in system extensions were checked and
seem proper.

Resolves: #105611
Releases: main, 13.4, 12.4
Change-Id: I9a78db529e69b46588923a3d764f7d83f6e1cc16
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87015
Reviewed-by: Garvin Hicking <[email protected]>
Tested-by: Garvin Hicking <[email protected]>
TYPO3IncTeam pushed a commit to TYPO3-CMS/form that referenced this issue Nov 18, 2024
@linawolf @fe-hicking
[DOCS] Fix interlink-shortcodes in EXT:form and EXT:styleguide
f59f8b0 
EXT:styleguide had a typo in the interlink-shortcode,
and EXT:form was missing an interlink-shortcode.

See also TYPO3-Documentation/render-guides#827

Other guides.xml in system extensions were checked and
seem proper.

Resolves: #105611
Releases: main, 13.4, 12.4
Change-Id: I9a78db529e69b46588923a3d764f7d83f6e1cc16
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87002
Reviewed-by: Chris Müller <[email protected]>
Tested-by: Garvin Hicking <[email protected]>
Reviewed-by: Benni Mack <[email protected]>
Reviewed-by: Garvin Hicking <[email protected]>
Tested-by: core-ci <[email protected]>
TYPO3IncTeam pushed a commit to TYPO3-CMS/styleguide that referenced this issue Nov 18, 2024
@linawolf @fe-hicking
[DOCS] Fix interlink-shortcodes in EXT:form and EXT:styleguide
1507ca3 
EXT:styleguide had a typo in the interlink-shortcode,
and EXT:form was missing an interlink-shortcode.

See also TYPO3-Documentation/render-guides#827

Other guides.xml in system extensions were checked and
seem proper.

Resolves: #105611
Releases: main, 13.4, 12.4
Change-Id: I9a78db529e69b46588923a3d764f7d83f6e1cc16
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87002
Reviewed-by: Chris Müller <[email protected]>
Tested-by: Garvin Hicking <[email protected]>
Reviewed-by: Benni Mack <[email protected]>
Reviewed-by: Garvin Hicking <[email protected]>
Tested-by: core-ci <[email protected]>
TYPO3IncTeam pushed a commit to TYPO3-CMS/form that referenced this issue Nov 18, 2024
@linawolf @fe-hicking
[DOCS] Fix interlink-shortcodes in EXT:form and EXT:styleguide
8d64860 
EXT:styleguide had a typo in the interlink-shortcode,
and EXT:form was missing an interlink-shortcode.

See also TYPO3-Documentation/render-guides#827

Other guides.xml in system extensions were checked and
seem proper.

Resolves: #105611
Releases: main, 13.4, 12.4
Change-Id: I9a78db529e69b46588923a3d764f7d83f6e1cc16
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87016
Tested-by: core-ci <[email protected]>
Tested-by: Garvin Hicking <[email protected]>
Reviewed-by: Garvin Hicking <[email protected]>
TYPO3IncTeam pushed a commit to TYPO3-CMS/form that referenced this issue Nov 18, 2024
@linawolf @fe-hicking
[DOCS] Fix interlink-shortcodes in EXT:form and EXT:styleguide
c6b3ae8 
EXT:styleguide had a typo in the interlink-shortcode,
and EXT:form was missing an interlink-shortcode.

See also TYPO3-Documentation/render-guides#827

Other guides.xml in system extensions were checked and
seem proper.

Resolves: #105611
Releases: main, 13.4, 12.4
Change-Id: I9a78db529e69b46588923a3d764f7d83f6e1cc16
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87015
Reviewed-by: Garvin Hicking <[email protected]>
Tested-by: Garvin Hicking <[email protected]>
TYPO3IncTeam pushed a commit to TYPO3-CMS/styleguide that referenced this issue Nov 18, 2024
@linawolf @fe-hicking
[DOCS] Fix interlink-shortcodes in EXT:form and EXT:styleguide
76a4411 
EXT:styleguide had a typo in the interlink-shortcode,
and EXT:form was missing an interlink-shortcode.

See also TYPO3-Documentation/render-guides#827

Other guides.xml in system extensions were checked and
seem proper.

Resolves: #105611
Releases: main, 13.4, 12.4
Change-Id: I9a78db529e69b46588923a3d764f7d83f6e1cc16
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87015
Reviewed-by: Garvin Hicking <[email protected]>
Tested-by: Garvin Hicking <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garvinhicking @linawolf