Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Opening file with an '&' fails #666

Closed
3 tasks done
SkeleyM opened this issue Dec 23, 2024 · 4 comments · Fixed by #667
Closed
3 tasks done

[Bug]: Opening file with an '&' fails #666

SkeleyM opened this issue Dec 23, 2024 · 4 comments · Fixed by #667
Labels
Priority: High An important issue requiring attention Type: Bug Something isn't working as intended Type: File System File system interactions

Comments

@SkeleyM
Copy link
Contributor

SkeleyM commented Dec 23, 2024

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

Alpha v9.5.0 (main branch)

Operating System & Version

Windows 10 22H2

Description

Clicking on the file preview to open the file fails when the path contains an ampersand ('&')

The '&' gets interpreted as a shell command
image

Expected Behavior

The file should be opened regardless of if the path contains an & or not

Steps to Reproduce

  1. Rename a file to contain an '&' or have one in a folder with an '&' in the name
  2. Click the preview of the file in tag studio

Logs

2024-12-23 14:44:47 [info ] Opening file path=WindowsPath('C:/Users/user/Pictures/path&path/waw.PNG')
The system cannot find the file C:\Users\user\Pictures\path.

@SkeleyM SkeleyM added the Type: Bug Something isn't working as intended label Dec 23, 2024
@SkeleyM SkeleyM changed the title [Bug]: Opening file with an '&' [Bug]: Opening file with an '&' fails Dec 23, 2024
@Toby222
Copy link

Toby222 commented Dec 23, 2024

You didn't censor the user name in the header of the error box

@SkeleyM
Copy link
Contributor Author

SkeleyM commented Dec 23, 2024

thanks man

@CyanVoxel CyanVoxel added Priority: High An important issue requiring attention Type: File System File system interactions labels Dec 24, 2024
@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Dec 24, 2024
@CyanVoxel CyanVoxel moved this to 🚧 In progress in TagStudio Development Dec 24, 2024
@kana800
Copy link

kana800 commented Jan 3, 2025

I was able to reproduce the steps and got same issue.

image


PR #667 fix worked for me ! @CyanVoxel

image

proof

image

hope this help;

image reference

@CyanVoxel
Copy link
Member

I was able to reproduce the steps and got same issue.

hope this help;

This helps a ton! Thank you so much!

@github-project-automation github-project-automation bot moved this from 🚧 In progress to ✅ Done in TagStudio Development Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention Type: Bug Something isn't working as intended Type: File System File system interactions
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants