Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undertow-io/undertow, d0efffad5d2034bb07525cac9b299dac72c3045d, io.undertow.websockets.jsr.test.JsrWebSocketServer07Test.testErrorHandling #1482

Open
Derrick2000 opened this issue Nov 13, 2024 · 0 comments

Comments

@Derrick2000
Copy link
Contributor

In JsrWebSocketServer07Test, the method testErrorHandling is not marked with @org.junit.Test. Instead, there's a line of comment on top:
https://github.com/undertow-io/undertow/blob/b44a1c3a52da8f9a57bbdaa989c5ac18d2f03e38/websockets-jsr/src/test/java/io/undertow/websockets/jsr/test/JsrWebSocketServer07Test.java#L647

I believe authors of this repo is currently excluding this test case, so resolving its flakiness seems unnecessary.

Also, the same goes to
JsrWebSocketServer08Test#testErrorHandling
JsrWebSocketServer13Test#testErrorHandling
where both of the test classes extend JsrWebSocketServer07Test without overriding testErrorHandling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant