carson and max c #77
carson and max c #77
Conversation
src/main/java/frc/robot/subsystems/shooter/FlywheelConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/shooter/FlywheelIOTalonFX.java
Outdated
Show resolved
Hide resolved
| ShooterConstants.AUTO_LINEUP_ROTATION_I, | ||
| ShooterConstants.AUTO_LINEUP_ROTATION_D, | ||
| ShooterConstants.AUTO_LINEUP_ROTATION_CONSTRAINTS); | ||
| FlywheelConstants.AUTO_LINEUP_ROTATION_P, |
There was a problem hiding this comment.
why did we rename this? I think ShooterConstants was more accurate, especially for this case. The auto lineup stuff doesn't have anything to do with specifically the flywheel
There was a problem hiding this comment.
it was renamed to match the subsystem name. imo auto lineup constants should actually go in trajectory constants bc the shooter isn't the thing thats lining up w/ the amp, the swerve is.
There was a problem hiding this comment.
yeah we should move it to trajectory constants, also consider renaming trajectory constants to auto constants
There was a problem hiding this comment.
Looks like im right so Im keeping it as flywheel
There was a problem hiding this comment.
Bro did not read the conversation
There was a problem hiding this comment.
Bro did not read the conversation
src/main/java/frc/robot/subsystems/shooter/FlywheelIOTalonFX.java
Outdated
Show resolved
Hide resolved
|
its been so long i forgot there was a pr open for this 💀 |
|
@mychenezpz please make the changes requested in the pull request |
| ShooterConstants.AUTO_LINEUP_ROTATION_I, | ||
| ShooterConstants.AUTO_LINEUP_ROTATION_D, | ||
| ShooterConstants.AUTO_LINEUP_ROTATION_CONSTRAINTS); | ||
| FlywheelConstants.AUTO_LINEUP_ROTATION_P, |
There was a problem hiding this comment.
Looks like im right so Im keeping it as flywheel
No description provided.