Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a method for approving admin events #411

Open
Caleb-Cohen opened this issue May 9, 2023 · 2 comments
Open

Create a method for approving admin events #411

Caleb-Cohen opened this issue May 9, 2023 · 2 comments

Comments

@Caleb-Cohen
Copy link
Member

Related Issues
Project: Admin Dashboard
Depends on:

Description
Create a method in the events.js controller called approveEvents
Method will change specific event objects status to approved
Create post route in events.js
Create axios request

Acceptance Criteria
Test updated event object has been changed from pending to approved

@cblanken
Copy link
Contributor

@Caleb-Cohen I'd like to take this issue if I could get assigned whenever you have a chance.

@cblanken
Copy link
Contributor

cblanken commented Aug 29, 2023

A couple things I noticed from my first look at this issue

  • It's unclear from the description whether the endpoint approveEvents method should take a single event or many to be approved all at once. I think the second case makes the most sense since you could also just provide a single event as well, but it might also make sense to add separate endpoints for approveEvent (singular) and approveEvents (multiple) for clarity. I just wanted to get clarification before making a decision.
  • I believe a PATCH would be more appropriate here instead of POST since we should only be updating a single property on each event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants