Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced processing time for PDHG-TV and PDHG -TGV for the multichannel colour notebook #191

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Reduced processing time for PDHG-TV and PDHG -TGV for the multichannel colour notebook #191

merged 5 commits into from
Oct 23, 2024

Conversation

MargaretDuff
Copy link
Member

No description provided.

@MargaretDuff
Copy link
Member Author

Closes #185

@lauramurgatroyd lauramurgatroyd linked an issue Oct 16, 2024 that may be closed by this pull request
Colour Processing notebook takes too long to run #185
Closed
@MargaretDuff MargaretDuff self-assigned this Oct 16, 2024
@MargaretDuff MargaretDuff added this to the CIL User Meeting milestone Oct 16, 2024
lauramurgatroyd
lauramurgatroyd approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, much faster and still looks well denoised 😄

But please clear output before merging!

@MargaretDuff
Copy link
Member Author

MargaretDuff commented Oct 23, 2024 •
edited
Loading

Closes #198: I added some instructions for windows. @lauramurgatroyd - please can you have a look?

@MargaretDuff MargaretDuff linked an issue Oct 23, 2024 that may be closed by this pull request
Error with font not found in Colour Processing Notebook - Windows 11 and New Training Platform (linux) #198
Open
@lauramurgatroyd lauramurgatroyd self-requested a review October 23, 2024 10:33
lauramurgatroyd
lauramurgatroyd approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@lauramurgatroyd
Copy link
Member

Please add yourself to authors before merging

@MargaretDuff MargaretDuff merged commit 1bad747 into TomographicImaging:main Oct 23, 2024
@MargaretDuff MargaretDuff deleted the colour_multichannel branch October 23, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauramurgatroyd lauramurgatroyd lauramurgatroyd approved these changes

Assignees

@MargaretDuff MargaretDuff

Labels
None yet
Projects
None yet
Milestone
CIL User Meeting
2 participants
@MargaretDuff @lauramurgatroyd