Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentence reporters to Text #1768

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

man-o-valor
Copy link

@man-o-valor man-o-valor commented Nov 30, 2024

Added Sentence Case, camelCase, Randomcase and Surround

Also, my first commit/pr in another repo :) excuse me if my code is a little less clean than cst's

Added Sentence Case, camelCase, Randomcase, Surround, Enter, Tab, and Reverse

Also, my first commit/pr in another repo :) excuse me if my code is a little less clean than cst's
@man-o-valor
Copy link
Author

linter caught smth ill fix it later cant rn

@man-o-valor
Copy link
Author

I don't know how to make the Prettier happy, can someone do it for me or show me how to

@man-o-valor
Copy link
Author

Also this can get the Change Existing Extension label

@GarboMuffin GarboMuffin added the pr: change existing extension Pull requests that change an existing extension label Nov 30, 2024
@Thebloxers998
Copy link

I don't know how to make the Prettier happy, can someone do it for me or show me how to

Me too :)

extensions/text.js Outdated Show resolved Hide resolved
@yuri-kiss
Copy link
Member

yuri-kiss commented Dec 25, 2024

Additional testing required before this is merged, as well as some changes

extensions/text.js Outdated Show resolved Hide resolved
@man-o-valor
Copy link
Author

Why were Newline and Tab reverted, curious

@yuri-kiss
Copy link
Member

Why were Newline and Tab reverted, curious

newline is duplicate across a load of exts atp, and tab is just 4 spaces

@CST1229
Copy link
Collaborator

CST1229 commented Dec 25, 2024

newline is duplicate across a load of exts atp, and tab is just 4 spaces

tab wouldn't be 4 spaces if it was a \t

@yuri-kiss
Copy link
Member

newline is duplicate across a load of exts atp, and tab is just 4 spaces

tab wouldn't be 4 spaces if it was a \t

\t doesnt work correctly in stuff like the say block, and the original block just returned spaces.

If you really need the tab character just use the unicode block

extensions/text.js Outdated Show resolved Hide resolved
@GarboMuffin

This comment was marked as outdated.

@GarboMuffin
Copy link
Member

Okay. Mixed case was already in the extension and was already broken. So not your fault

extensions/text.js Outdated Show resolved Hide resolved
extensions/text.js Outdated Show resolved Hide resolved
Renamed sum to workingText and capflag to sentenceCapitalFlag
@man-o-valor
Copy link
Author

Also I fixed the mixed case test, it was just swapped around and no one ever caught it

@man-o-valor
Copy link
Author

This is ready for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: change existing extension Pull requests that change an existing extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants