Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically drain nodes if their TTL expires #17

Open
TwiN opened this issue Jan 31, 2023 · 3 comments
Open

Automatically drain nodes if their TTL expires #17

TwiN opened this issue Jan 31, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@TwiN
Copy link
Owner

TwiN commented Jan 31, 2023

Describe the feature request

If a resource of type node has a TTL which expired, attempt to drain the node before deleting it.

Note that for the first implementation, the drain process can be non-graceful (i.e. it can use the equivalent of kubectl drain node --disable-eviction, which bypasses PDBs).

Why do you personally want this feature to be implemented?

To handle node deletion slighly more gracefully.
Hopefully, it will work alongside cluster-autoscaler to provide a slightly better experience than just deleting the node.

How long have you been using this project?

No response

Additional information

No response

@TwiN TwiN added the enhancement New feature or request label Jan 31, 2023
@dmarquez-splunk
Copy link

instead of automatically draining can this be configuration based with the option to cordon the node and/or drain?

The motivation is that we have users on our clusters that have argo workflows that run on nodes that cannot be automatically pruned. We need to allow their workflows to complete before draining. In which case we can configure ttl to cordon them instead of draining, allow the workflows to finish, and the cluster auto scaler will take care of removing the node as it will meet the criteria for scaling down candidate.

+1 on this feature though!

@TwiN
Copy link
Owner Author

TwiN commented Nov 4, 2024

@dmarquez-splunk yep, that's an excellent idea!

@dmarquez-splunk
Copy link

Are you able to provide a rough estimate of when something like this can be supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants