Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe add limiting the number of results to the User example code? #239

Open
NicMcPhee opened this issue Mar 13, 2022 · 2 comments
Open
Labels

Comments

@NicMcPhee
Copy link
Member

NicMcPhee commented Mar 13, 2022

A lot of groups get the logic wrong for limiting the number of responses, often by limiting first and then filtering, which frequently yields fewer results than desired/expected.

We could make this less likely by including an example of limiting in the example User code. That said, they already do a lot of "copy/paste" problem solving in these labs, and I'm not sure we want to give them everything?

Also, we have very few users in this lab, so that kind of limited wouldn't make a lot of sense at the moment. We have a lot more later on in the DB lab (I think?), so we could just copy the larger set of users up to this lab.

@kklamberty
Copy link
Member

We might consider putting some end-to-end tests in this lab that we give them and put them in the actions... and maybe show the students how to run them?

@kklamberty
Copy link
Member

@NicMcPhee - I've given this some further thought, and what about giving a bit more detail in a "spec" written in English that explains that they should filter first and THEN limit, with an explanation/example of why/what it could look like if you don't do things in that order? It's a step between incorporating tests and making an example. It still asks them to do this in a particular order (and can serve as a reminder to those of us grading that we should check that), but it doesn't go so far as to give them something they can copy/paste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants