Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtPos/advmod for quantitative "at (the) least/most" #553

Open
2 tasks
nschneid opened this issue Dec 3, 2024 · 7 comments
Open
2 tasks

ExtPos/advmod for quantitative "at (the) least/most" #553

nschneid opened this issue Dec 3, 2024 · 7 comments

Comments

@nschneid
Copy link
Contributor

nschneid commented Dec 3, 2024

Some instances of "at least" attaching as nmod to a det-dependent ("at least some...") are now triggering validator errors. See UniversalDependencies/docs#1059 (comment). We might as well change them all to specify ExtPos=ADV and attach as advmod rather than nmod.

Note: non-quantitative "at least" and "at most" are considered fixed expressions, so they are already taken care of.

@amir-zeldes
Copy link
Contributor

We might as well change them all to specify ExtPos=ADV and attach as advmod rather than nmod.

Wouldn't that mean that we are starting to treat all "at least"s as fixed expressions?

@nschneid
Copy link
Contributor Author

nschneid commented Dec 3, 2024

It would still be saying they are PPs internally, which I think is fair. Though TBH I don't understand the syntactic reason for distinguishing the quantitative and non-quantitative ones—isn't it just a matter of idiomatic meaning?

@amir-zeldes
Copy link
Contributor

It would still be saying they are PPs internally

Wait, are you saying you want to keep obl+case for non quantitative "at least", but you want to put ExtPos=ADV on the head? I'm not sure that makes sense to me - obl dependents are already adverbial in the sense that any adverbial PP is, so I don't see what this adds. It makes more sense for the fixed version (with quantities).

@nschneid
Copy link
Contributor Author

nschneid commented Dec 5, 2024

Right now it's the nonquantity ones that are fixed. Which I find confusing.

What about dispensing with fixed entirely:

at/case least/ADJ[ExtPos=ADV]/advmod 3 books

at/case least/ADJ[ExtPos=ADV]/advmod some homework

at/case least/ADJ/obl you are having fun

@amir-zeldes
Copy link
Contributor

I agree it's confusing, and I'd be for making them all be the same. But I don't think we should have a compositional looking subtree with case and then use advmod + ExtPos. I'd do either or:

  1. Keep obl + case, then it's just compositional and there's no need for advmod or ExtPos
  2. Decide it's a special multi-word adverbial, then use fixed + advmod + ExtPos

I feel like mixing the two strategies is confusing.

@nschneid
Copy link
Contributor Author

nschneid commented Dec 6, 2024

The problem is we can't do nmod+case for "at least some (books)", because the validator now prohibits it.

@amir-zeldes
Copy link
Contributor

That suggests we should prefer fixed+advmod, which is fine by me, though I will note there are variants ("at the least" comes to mind, or "at the very least")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants