Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brew types should be data-driven #4690

Open
TheRealWormbo opened this issue Jun 24, 2024 · 1 comment
Open

Brew types should be data-driven #4690

TheRealWormbo opened this issue Jun 24, 2024 · 1 comment
Labels
after-1.21-port This will not be fixed/implemented before the port to 1.21 enhancement Enhancement that might be implemented in the future

Comments

@TheRealWormbo
Copy link
Collaborator

Mod Loader

Both Fabric and Forge (I confirm that I have tested both loaders and will specify both loader versions below)

Minecraft Version

1.21

Botania version

future

Modloader version

(any)

Modpack info

No response

The latest.log file

(n/a)

Issue description

Brew types, as in the collection of a mana cost, a color, and a list of one or more mob effects, should be defined in JSON files instead of requiring registration in code.

Steps to reproduce

No response

Other information

No response

@TheRealWormbo TheRealWormbo added the enhancement Enhancement that might be implemented in the future label Jun 24, 2024
@TheRealWormbo TheRealWormbo added the after-1.21-port This will not be fixed/implemented before the port to 1.21 label Jul 13, 2024
@TheRealWormbo
Copy link
Collaborator Author

I'm trying to think if there are any good ways to prevent data packs from breaking things by removing brews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
after-1.21-port This will not be fixed/implemented before the port to 1.21 enhancement Enhancement that might be implemented in the future
Development

No branches or pull requests

1 participant