-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPlot: fix label position and annotate color bar #39
Conversation
c802f96
to
f697111
Compare
Cool. But the idea is that cell regions are in pastel colors and boundary regions in bright. |
True, the colors are wrong. That is hopefully not so difficult to fix. And that thy the annotation "boundary regions" is so important :) |
f697111
to
55d0180
Compare
Sigh. It does not seem as simple as it looks. The problem here is that originally, we create a I uploaed a HACK!! where we simply use @j-fu Do you know how to make this elegantly in the code? |
Not really. May be it works as well if you plot just one triangle for the first plot. |
55d0180
to
702fbae
Compare
Rebased. I changed the dummy plot to plot only one triangle (I extract the first 3 coordinates). Results are as shown before. |
Well, it crashes for me. Can you try what I described: https://wias-pdelib.github.io/GridVisualize.jl/stable/contributing/ on your computer ? (it may make sense to check the pyplot case along with CairoMakie and PlutoVista in the CI). |
Thanks for the pointer, I didn't know that one. I'll add some code to the unit tests that catch the failure. |
This PR does the following in
gridplot
withPyPlot
Before:
After: