Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment test failure on the latest testsuite #55

Closed
CharlieTap opened this issue Aug 29, 2024 · 3 comments
Closed

Alignment test failure on the latest testsuite #55

CharlieTap opened this issue Aug 29, 2024 · 3 comments

Comments

@CharlieTap
Copy link

I also posted this here: WebAssembly/testsuite#96

Effectively the latest testsuite has tests for exponents greater than 64 which falls into the condition where the mem index is encoded, and thus fails. The proposal should probably copy align.wast and alter those tests to account for the exponent subtraction.

@rossberg
Copy link
Member

I updated the repo by syncing with upstream and removing the tests in question (since they are no longer meaningful in the presence of multi-memory).

FWIW, the issue is also closely related to the ongoing discussion on WebAssembly/spec#1788.

@CharlieTap
Copy link
Author

CharlieTap commented Aug 29, 2024

Looks like it might have failed one of the CI checks but thank you!

@rossberg
Copy link
Member

That looks like node.js failing one of the tests. Maybe it's current V8 isn't up-to-date enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants