Refactor elements #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
==========================================
+ Coverage 97% 97.79% +0.78%
==========================================
Files 52 54 +2
Lines 1471 1452 -19
Branches 154 153 -1
==========================================
- Hits 1427 1420 -7
+ Misses 37 25 -12
Partials 7 7
Continue to review full report at Codecov.
|
SoluMilken
force-pushed
the
refactor_elements
branch
from
79299fb to
3ed772d
Compare
SoluMilken
force-pushed
the
refactor_elements
branch
from
3ed772d to
4f2554a
Compare
SoluMilken
force-pushed
the
refactor_elements
branch
from
70c3762 to
41501f9
Compare
SoluMilken
requested review from
stegben,
absolutelyNoWarranty,
GBLin5566,
Liangtaiwan and
noobOriented
SoluMilken
force-pushed
the
refactor_elements
branch
from
3fa9daa to
4513c28
Compare
SoluMilken
commented
Jan 31, 2019
uttut/elements/datum.pxd
Outdated
| cdef class Datum: # noqa: E999 | ||
|
|
||
| cdef public str utterance | ||
| cdef public object intents |
SoluMilken
commented
Jan 31, 2019
uttut/elements/datum.pxd
Outdated
|
|
||
| cdef public str utterance | ||
| cdef public object intents | ||
| cdef public object entities |
SoluMilken
commented
Jan 31, 2019
| object intents=None, # : List[Intent] = None, | ||
| object entities=None, # : List[Entity] = None, | ||
| ): | ||
| self.utterance = utterance |
There was a problem hiding this comment.
cdef Entity entity, next_entity
cdef unsigned int idx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uttut/elements.pyxinto three scripts (datum.pyx,intent.pyx,entity.pyx) and move them into an independent folderelements/.