Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the beatmap has no music, the replay will not play. #79

Open
Andrey94-1 opened this issue Sep 23, 2022 · 1 comment
Open

If the beatmap has no music, the replay will not play. #79

Andrey94-1 opened this issue Sep 23, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Andrey94-1
Copy link

It's easy to check, just delete the music from the beatmap folder, make a replay and f2.
I found this error on this beatmap↓.
https://osu.ppy.sh/beatmapsets/30229#osu/121594
@Andrey94-1 Andrey94-1 added the bug Something isn't working label Sep 23, 2022
@Andrey94-1 Andrey94-1 changed the title If the betmap has no music, the replay will not play. If the beatmap has no music, the replay will not play. Sep 23, 2022
@abstrakt8
Copy link
Owner

abstrakt8 commented Apr 11, 2023 •
edited
Loading

True because I'm calculating the duration of the replay from the underlying mp3 file, but I think I could instead use the max time value from the replay instead in case the mp3 file is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abstrakt8 @Andrey94-1