Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for using URL in jdkFile #232

Closed
morki opened this issue Sep 15, 2021 · 1 comment · May be fixed by #281
Closed

Support for using URL in jdkFile #232

morki opened this issue Sep 15, 2021 · 1 comment · May be fixed by #281
Labels
feature request New feature or request to improve the current logic wontfix This will not be worked on

Comments

@morki
Copy link

morki commented Sep 15, 2021

Description:
It would be awesome to support URLs in addition to local paths for jdkFile input.

Justification:
It should resolve all issues with custom Java distributions and versions and speed up builds by caching the downloaded result zip (key can be URL).

Are you willing to submit a PR?
No.
@morki morki added feature request New feature or request to improve the current logic needs triage labels Sep 15, 2021
ghost referenced this issue Sep 25, 2021
@thboop
update contributing.md
16bc090
@ghost ghost deleted a comment Nov 8, 2021
mdvorak added a commit to mdvorak/setup-java that referenced this issue Jan 17, 2022
@mdvorak
Add support for http url in jdkFile
d875d99 
Closes actions#232
mdvorak added a commit to mdvorak/setup-java that referenced this issue Jan 17, 2022
@mdvorak
Add support for http url in jdkFile
b61c881 
Closes actions#232
mdvorak added a commit to mdvorak/setup-java that referenced this issue Jan 17, 2022
@mdvorak
Add support for http url in jdkFile
a8a059b 
Closes actions#232
@mdvorak mdvorak mentioned this issue Jan 17, 2022
Open
2 tasks
mdvorak added a commit to mdvorak/setup-java that referenced this issue Mar 16, 2022
@mdvorak
Add support for http url in jdkFile
ebc13aa 
Closes actions#232
@IvanZosimov IvanZosimov linked a pull request Jul 3, 2023 that will close this issue
Support http url directly in jdkFile #281
Open
2 tasks
@IvanZosimov
Copy link
Contributor

Hi, @morki 👋 We investigated your feature request thoroughly, but unfortunately we have to reject it because of the possible licenses and security issues associated with this feature.

@IvanZosimov IvanZosimov closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
@IvanZosimov IvanZosimov added the wontfix This will not be worked on label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support http url directly in jdkFile mdvorak/setup-java
3 participants
@morki @dmitry-shibanov @IvanZosimov