Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spans containing only svgs are being deleted #444

Open
alexcarol opened this issue Nov 29, 2024 · 0 comments · May be fixed by #445
Open

Spans containing only svgs are being deleted #444

alexcarol opened this issue Nov 29, 2024 · 0 comments · May be fixed by #445
Labels
bug Something isn't working

Comments

@alexcarol
Copy link

Description
Spans containing only svgs are being deleted in the import "cleanup" step.

To Reproduce
1.Import a page that has a span containing only an svg element.
2.In the "transform" function of the import script use querySelector to find said svg

Expected behavior
Spans containing svgs remain intact

Version:
16.7.25
@alexcarol alexcarol added the bug Something isn't working label Nov 29, 2024
@alexcarol alexcarol linked a pull request Nov 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Prevent spans containing svgs from being removed alexcarol/helix-importer
1 participant
@alexcarol