Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The scheme option description unclear #88

Open
karollewandowski opened this issue Jun 4, 2020 · 0 comments
Open

The scheme option description unclear #88

karollewandowski opened this issue Jun 4, 2020 · 0 comments
Assignees
Milestone

Comments

@karollewandowski
Copy link
Contributor

It states:

scheme - allows adding or removing the scheme part for a URI

${'//example.com/path/page.html' @ scheme='http'}
<!-- outputs: http://example.com/path/page.html -->

${'http://example.com/path/page.html' @ scheme='https'}
<!-- outputs: https://example.com/path/page.html -->

${'http://example.com/path/page.html' @ scheme=''}
<!-- outputs: http://example.com/path/page.html -->

${'http://example.com/path/page.html' @ scheme}
<!-- outputs: http://example.com/path/page.html -->

It looks like it doesn't remove scheme, even in examples above. I checked Sightly implementation and it also doesn't remove scheme.
I assume that removed scheme means the following output:

${'http://example.com/path/page.html' @ scheme=''}
<!-- outputs: //example.com/path/page.html -->

Could you please clarify it?

@raducotescu raducotescu self-assigned this Aug 17, 2022
@raducotescu raducotescu added this to the 1.4.1 milestone Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants