Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[combobox] accessibility in documentation #1161

Open
GarthDB opened this issue Apr 1, 2021 · 1 comment
Open

[combobox] accessibility in documentation #1161

GarthDB opened this issue Apr 1, 2021 · 1 comment
Labels
documentation Because documentation is important and shouldn't be broken storybook

Comments

@GarthDB
Copy link
Member

GarthDB commented Apr 1, 2021

Description

Combobox is not currently using the correct DOM for Aria.

React Spectrum might have worked toward fixing this in their code base.

@GarthDB GarthDB added bug Results from a bug in the CSS implementation a11y Questions or topics for the accessibility team Component: Combo Box labels Apr 1, 2021
@castastrophe
Copy link
Collaborator

PickerButton seems to be using the right arias in our Storybook though we haven't mapped all the appropriate events (just click) so that the interaction isn't reflecting a production implementation.

Can we update the goal of this issue to cover adding expected events to the demo as well?

https://opensource.adobe.com/spectrum-css/?path=/story/components-combobox--default

@castastrophe castastrophe added storybook documentation Because documentation is important and shouldn't be broken and removed a11y Questions or topics for the accessibility team bug Results from a bug in the CSS implementation labels Dec 10, 2024
@castastrophe castastrophe changed the title Combobox Accessibility Combobox Accessibility in documentation Dec 10, 2024
@castastrophe castastrophe changed the title Combobox Accessibility in documentation [combobox] accessibility in documentation Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Because documentation is important and shouldn't be broken storybook
Projects
None yet
Development

No branches or pull requests

2 participants