Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ActionButton, ActionGroup] examples should be accessible #2853

Open
astearns opened this issue Jun 19, 2024 · 1 comment
Open

[ActionButton, ActionGroup] examples should be accessible #2853

astearns opened this issue Jun 19, 2024 · 1 comment
Assignees
@pfulton @castastrophe
Labels
bug Results from a bug in the CSS implementation documentation Because documentation is important and shouldn't be broken jira ticket created size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. triage Needs to be reproduced & prioritized

Comments

@astearns
Copy link

Description

The Storybook Action button (and Action group) examples do not have an accessible name in the icon-only versions. The versions that have a name in the markup have a duplicate aria-label attribute, but the ones that do not have a name in the markup are missing that attribute.

Link to documentation

https://opensource.adobe.com/spectrum-css/preview/index.html?path=/story/components-action-button--default

Additional context

I assume the stories/template should be set up more like the spectrum-Button examples, which add an aria-label attribute for the versions with no markup name, and do not add the attribute for the versions with the name in the markup. I’d be happy to submit a PR with this documentation fix if this is correct.
@astearns astearns added the documentation Because documentation is important and shouldn't be broken label Jun 19, 2024
@castastrophe castastrophe added bug Results from a bug in the CSS implementation size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. triage Needs to be reproduced & prioritized labels Jul 3, 2024
@marissahuysentruyt marissahuysentruyt mentioned this issue Oct 10, 2024
Merged
19 tasks
@castastrophe castastrophe changed the title Action button and Action Group examples should be accessible [ActionButton, ActionGroup] examples should be accessible Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfulton pfulton

@castastrophe castastrophe

Labels
bug Results from a bug in the CSS implementation documentation Because documentation is important and shouldn't be broken jira ticket created size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. triage Needs to be reproduced & prioritized
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pfulton @astearns @castastrophe @marissahuysentruyt and others