Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change invalid error message when first two bytes of method begin with \x16\x03 #10142

Open
bdraco opened this issue Dec 7, 2024 · 0 comments

Comments

@bdraco
Copy link
Member

bdraco commented Dec 7, 2024

I think it makes sense to make it a debug log at this point, though the noisiness in the past has been pretty helpful as most exceptions reported turned out to be parser bugs. I'm a lot more confident in the parser these days, so don't mind reducing the output.

But, even logging, we should improve the error message in this specific case by checking the first 2 bytes are \x16\x03 to make it easier to debug. Surely all those homeassistant issues will be more difficult for users to debug with the linked PR? i.e. They are now less likely to see the errors and those errors still don't explain the issue with their client clearly. I think HTTPS on HTTP port is such a common case that we can special case it. @bdraco Maybe something even simpler than #10067 and just change the error message (rather than the exception class)?

Originally posted by @Dreamsorcerer in #8065 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant