Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimatedGridLines issue with React-spring 9.0.0 #1122

Closed
DanielHuntleySBG opened this issue Mar 27, 2021 · 4 comments · Fixed by #1277
Closed

AnimatedGridLines issue with React-spring 9.0.0 #1122

DanielHuntleySBG opened this issue Mar 27, 2021 · 4 comments · Fixed by #1277

Comments

@DanielHuntleySBG
Copy link

Issue:
Upgrading to the latest React-spring version (9.0.0) causes issues with the animated components.

Error:
Cannot read property 'fromX' of undefined (AnimatedGridLines.js:29)

Example Sandbox:
https://codesandbox.io/s/runtime-monad-orc12

@achhunna
Copy link

achhunna commented Apr 7, 2021

Having the same issue as well. Any idea what the solution is?

@williaster
Copy link
Collaborator

react-spring@9 had a ton of breaking changes so I think we'll need to update the relevant @visx/* packages to 9 and probably release 2.0.0 @visx versions. I don't think there's a way to have compatibility with both 8 & 9 unfortunately.

@joernroeder
Copy link

would love to see v9 support as well

@williaster
Copy link
Collaborator

Note this is released in v2.0.0-alpha.0, we are trying to lump the react-17 upgrade into the 2.0.0 release as well hence the alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants