-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing approaches in this project #918
Comments
Hey @m0t0r thanks for creating this issue 🙏 (and sorry about the complexities of this as it relates to the Generally Airbnb is moving toward using As far as cypress / visual testing, we are planning to add screenshot testing with happo 🦛 soon (my plan is before end of 2020) for the Not sure if @hshoff has any other thoughts to add. |
Hi @williaster, great, thanks for your reply, I appreciate. Yes, migrating to |
My preference would be to wait for the official enzyme 17 adapter. Migrating the entire test suite to |
@hshoff are you also planning to use |
We currently use Also an update, we now use happo for visual testing of all gallery examples as added in #1030 |
@williaster @hshoff I have a few questions about testing approaches in this project. I understand Airbnb probably has its coding tools standards but I was wondering how strict they are ? :) For example, would it be possible to migrate from enzyme to a much better Testing Library. I also noticed use of shallow rendering in tests which is not the best approach. There is also cypress-react-unit-test which for projects like
visx
could be a nice option to consider as well, maybe not for all but some of the interactive tests because it renders in real browser. Could you share your thoughts ?The text was updated successfully, but these errors were encountered: