Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary page rendering when extracting highlights #10

Open
steven-kraft opened this issue Apr 15, 2021 · 0 comments · May be fixed by #11
Open

Unnecessary page rendering when extracting highlights #10

steven-kraft opened this issue Apr 15, 2021 · 0 comments · May be fixed by #11

Comments

@steven-kraft
Copy link

Hi, I noticed that await page.render(renderContext, annotations); gets called even if annotations.length is 0. Is there a reason for this?

I think making it so that only pages with annotations are rendered would greatly improve the time it takes to extract the highlights.

I think it depends on the PDF, but I timed that it takes about 100-200ms per page to render, making a 500 page pdf take 1-2 minutes regardless of the amount of annotations.

@steven-kraft steven-kraft linked a pull request Apr 15, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant