Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes #5

Open
akxcv opened this issue Feb 1, 2018 · 25 comments
Open

Themes #5

akxcv opened this issue Feb 1, 2018 · 25 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@akxcv
Copy link
Owner

akxcv commented Feb 1, 2018

I suggest the following API:

# use the "poop" theme:
krasivo hello --theme poop
# or, shorter:
krasivo hello -t poop

We can also support user-defined themes and settings via a ~/.krasivorc file or something. Example:

# ~/.krasivorc
default_theme: poodle
themes:
  poodle: :poodle: :poop:
  thoughtful_pray: :thinking_face: :pray::skin-tone-6:
# use "poodle" theme by default:
krasivo "no thanks"
# still able to use krasivo normally:
krasivo hey :no_good: :dog2:

This feature isn't that good without a selection of default themes that would be bundled with the package. And for that, I need help. Please offer your theme ideas here, if you have any.

@akxcv akxcv added the help wanted Extra attention is needed label Feb 1, 2018
@akxcv akxcv self-assigned this Feb 1, 2018
@akxcv
Copy link
Owner Author

akxcv commented Feb 1, 2018

@nesaulov @past-one @0exp @nulldef
🙏🏿🙏🏿🙏🏿🙏🏿🙏🏻🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏿🙏🏿🙏🏿
🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻
🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻
🙏🏿🙏🏿🙏🏿🙏🏿🙏🏻🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏿🙏🏿🙏🏻
🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿
🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿
🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏿🙏🏿🙏🏿🙏🏿🙏🏻🙏🏿🙏🏿🙏🏿🙏🏿🙏🏻

🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏻🙏🏿🙏🏿🙏🏿🙏🏻🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏿🙏🏿🙏🏿🙏🏻
🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿
🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿
🙏🏿🙏🏿🙏🏿🙏🏿🙏🏿🙏🏻🙏🏿🙏🏿🙏🏿🙏🏿🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏿🙏🏿🙏🏿🙏🏻
🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻
🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻
🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏿🙏🏻🙏🏿🙏🏿🙏🏿🙏🏿🙏🏿🙏🏻🙏🏿🙏🏻🙏🏻🙏🏻🙏🏻

@past-one
Copy link
Contributor

past-one commented Feb 1, 2018

I guess, theme names should be as short as possible

dog: :dog: :dog2:
top: :100: :+1:
bad: :poop: :-1:
tea: :tea: :fire:
think: :shipit: :thinking:

It also could be --list option to dump themes with descriptions into console.

@nulldef
Copy link

nulldef commented Feb 2, 2018

I agree with @akxcv, It seems to be the best API for it. But I guess that --list option is necessary.

@akxcv
Copy link
Owner Author

akxcv commented Feb 2, 2018

Yeah, I agree with the points you both made, but I'm most interested in theme ideas. I don't mean we should not discuss the API, I'm just trying to set the focus of our discussion.

So far, I like the 💯 👍, 💩 👎 themes. Not sure about 🍵 🔥 (why fire, exactly?)
:shipit: 🤔 theme looks good as well, but "think" doesn't quite sound right (there's a shade of secrecy b/c of :shipit:)

@nesaulov
Copy link
Contributor

nesaulov commented Feb 2, 2018

I will give some ideas tomorrow

@nesaulov
Copy link
Contributor

nesaulov commented Feb 3, 2018

Additional to the listed above:

  • 🏈 , :sports_medal: -> sports
  • 👋, 🚶 -> bye
  • 👍 , 🎉 ->celebration

@akxcv
Copy link
Owner Author

akxcv commented Feb 4, 2018

How about also having theme aliases? One could configure them like so:

# ~/.krasivorc
default_theme: poodle
themes:
  poodle: :poodle: :poop:
  thoughtful_pray: :thinking_face: :pray::skin-tone-6:
  doggy: poodle # alias

@akxcv akxcv mentioned this issue Feb 4, 2018
@nesaulov
Copy link
Contributor

nesaulov commented Feb 4, 2018

This doesn't seem to me as a necessary feature, to be honest. But why not ¯_(ツ)_/¯

@coremessage
Copy link

  • 🐃 💭

@nesaulov
Copy link
Contributor

What's the status of this issue? Is anyone working on it? I want to have this feature, but I don't want to contribute.

@akxcv
Copy link
Owner Author

akxcv commented May 14, 2018

I kind of want to work on this, but not really.

@0exp
Copy link

0exp commented Aug 7, 2018

No

@akxcv akxcv removed their assignment Dec 7, 2018
@akxcv akxcv added the enhancement New feature or request label Dec 7, 2018
@nesaulov
Copy link
Contributor

What's the status of this issue? Is anyone working on it? I want to have this feature, but I don't want to contribute.

@0exp
Copy link

0exp commented May 23, 2019

@akxcv DO IT NOW

@akxcv
Copy link
Owner Author

akxcv commented May 25, 2019

I kind of want to work on this, but not really.

@0exp
Copy link

0exp commented Jan 8, 2021

GDE RABOTA?

@akxcv
Copy link
Owner Author

akxcv commented Jan 8, 2021

Hz. @past-one?

@past-one
Copy link
Contributor

past-one commented Jan 8, 2021

A? @nulldef @nesaulov ? Ne?

@0exp
Copy link

0exp commented Jan 10, 2021

@nulldef @nesaulov vam zadali vopros

@akxcv
Copy link
Owner Author

akxcv commented Apr 22, 2021

@past-one @0exp @nesaulov @akxcv how long are you going to keep the people waiting?!

@0exp
Copy link

0exp commented Sep 9, 2024

What's the status of this issue? Is anyone working on it? I want to have this feature, but I don't want to contribute @nesaulov .

@0exp
Copy link

0exp commented Sep 9, 2024

@past-one could you please help us?

@0exp
Copy link

0exp commented Sep 10, 2024

@nulldef pomogi plz

@past-one
Copy link
Contributor

@nesaulov without you ne poreshat'

@nulldef
Copy link

nulldef commented Sep 20, 2024

@0exp go contrubute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants