Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a custom property to scope is not documented #129

Open
1TheMuffinMan opened this issue May 18, 2017 · 1 comment
Open

Adding a custom property to scope is not documented #129

1TheMuffinMan opened this issue May 18, 2017 · 1 comment

Comments

@1TheMuffinMan
Copy link

At the bottom of the documentation it says that you can add your own scope properties in addition to message and title, however there's a lot of documentation missing on that functionality.

There is no documentation that specifies that you must create your own scope, add your custom property to it and then set the undocumented scope property in the notification:

var scope = $rootScope.$new(false);
scope.event = notificationEvent;
//show toast
Notification({
    title: notificationEvent.displayText,
    scope: scope,
    templateUrl: '/client/app/core/ui/directives/events/signalrEventItem.html'
});

Would you accept a pull request for this?

@SuigetsuSake
Copy link

+1 For this, I needed this and couldn't know from the current docs

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants