Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of provider #131

Open
lesimoes opened this issue Jul 17, 2017 · 1 comment
Open

Change name of provider #131

lesimoes opened this issue Jul 17, 2017 · 1 comment

Comments

@lesimoes
Copy link

This provider has name 'Notification' same name of Web API Notification implements on all browsers.
You can use angularjs safe dependency injection to avoid this problem, but i believe this is bad practice that can generate conflicts.

In my project i override for 'angularNotification' and use safe dependency injection to tackle this problem

@bencun
Copy link

bencun commented Nov 9, 2017

+1
I agree on this suggestion for the very same reason as the OP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants