Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure shadow is removed when game is over #4

Open
alpgarcia opened this issue Aug 27, 2020 · 0 comments
Open

Make sure shadow is removed when game is over #4

alpgarcia opened this issue Aug 27, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@alpgarcia
Copy link
Owner

Sometimes part of the shadow will be still displayed after game over. This happens when the shape's new position is not valid and is less than the END_POS. The shape won't be placed on the grid, but part of the shadow could still be there because the shapes start falling from above the grid.

We could either remove those grid cells having their Color.alpha value distinct from 1 (that means they are transparent and that means they are part of the shadow) or try to make sure we only draw a shadow if the whole shadow is on the visible grid.

@alpgarcia alpgarcia added the enhancement New feature or request label Aug 27, 2020
alpgarcia added a commit that referenced this issue Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant