Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature for viewing submissions and searching by name and form name #54

Closed
wants to merge 3 commits into from
Closed

Add feature for viewing submissions and searching by name and form name #54

wants to merge 3 commits into from

Conversation

bismitaguha
Copy link
Contributor

@bismitaguha bismitaguha commented Aug 17, 2020 •
edited
Loading

Description

  • Added list view of submissions
  • Added feature for search by form name and user name
  • Added feature to view user profile and specific form responses
  • In the User profile, you can view their general details, Zulip stats & summary of all forms filled by them

Fixes #49

Type of Change:

  • Code
  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

  • submission/
    Screenshot from 2020-08-17 20-19-37

  • submission/:user_id
    Screenshot from 2020-08-28 11-12-39

  • preview/:form_id/:user_id -> To view the responses of a specific form for a specific user
    Screenshot from 2020-08-28 11-12-47

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented on my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • Any dependent changes have been published in downstream modules

@bismitaguha
Copy link
Contributor Author

CSS work left!

@bismitaguha bismitaguha requested review from sidvenu and abha224 August 17, 2020 14:53
sidvenu
sidvenu suggested changes Aug 21, 2020
View reviewed changes
Copy link

@sidvenu sidvenu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM till now - just remove the test log. Is this PR WIP?

src/components/Submission.js Outdated Show resolved Hide resolved
@sidvenu
Copy link

sidvenu commented Aug 27, 2020

Is this PR WIP or done? If done, please request a review. If not, please add 'WIP' to the title.

@bismitaguha bismitaguha requested a review from sidvenu August 28, 2020 05:48
@bismitaguha
Copy link
Contributor Author

bismitaguha commented Aug 28, 2020 •
edited
Loading

@abha224 @sidvenu This PR will require changes after the merge of the Zulip Stats PR. Please do not merge before that!!!

@abha224 abha224 added the Program: GSOC Related to work completed during the Google Summer of Code Program. label Aug 31, 2020
@isabelcosta isabelcosta added the Status: Needs Review PR needs an additional review or a maintainer's review. label Jan 24, 2021
@isabelcosta
Copy link
Member

isabelcosta commented Feb 14, 2021 •
edited
Loading

Will close due to inactivity, and make the issue available again.
Thank you for starting this work @bismitaguha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidvenu sidvenu sidvenu approved these changes

@abha224 abha224 Awaiting requested review from abha224

Assignees
No one assigned
Labels
Program: GSOC Related to work completed during the Google Summer of Code Program. Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat:View and modify status of all the form submissions
4 participants
@bismitaguha @sidvenu @isabelcosta @abha224