Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:updating package version #270

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore:updating package version #270

wants to merge 1 commit into from

Conversation

Anmollenka
Copy link

@Anmollenka Anmollenka commented Jul 10, 2021 •
edited
Loading

Description

Updated the version of the react-scripts dependency to 4.0.3 to avoid high severity warnings.

Fixes #194

Type of Change:

  • Code
    \

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

This has been tested locally after making the required changes.

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged
  • I have written Kotlin Docs whenever is applicable

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@Anmollenka Anmollenka requested a review from mtreacy002 as a code owner July 10, 2021 18:20
@welcome
Copy link

welcome bot commented Jul 10, 2021

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request.✨ AnitaB.org is an inclusive community, committed to creating a safe and positive environment.🌸Please adhere to our Code of Conduct and Contribution Guidelines.🙌.We will get back to you as soon as we can.😄

Feel free to join us on AnitaB.org Open Source Zulip Community.💖 We have different streams for each active repository for discussions.✨ Hope you have a great time there!😄

vj-codes
vj-codes requested changes Sep 20, 2021
View reviewed changes
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anmollenka please resolve the merge conflicts. Thanks!

@vj-codes vj-codes added the Status: Changes Requested Changes are required to be done by the PR author. label Sep 20, 2021
vj-codes
vj-codes requested changes Jan 1, 2022
View reviewed changes
Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anmollenka any updates on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vj-codes vj-codes vj-codes requested changes

@mtreacy002 mtreacy002 Awaiting requested review from mtreacy002 mtreacy002 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev: Update react-scripts dependency to remove high severity vulnerabilities
2 participants
@Anmollenka @vj-codes