Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Python Script to check new Samples on antmedia.io #5268

Closed
mekya opened this issue Jun 19, 2023 · 4 comments · Fixed by ant-media/Scripts#211 · May be fixed by ant-media/Scripts#216
Closed

Write Python Script to check new Samples on antmedia.io #5268

mekya opened this issue Jun 19, 2023 · 4 comments · Fixed by ant-media/Scripts#211 · May be fixed by ant-media/Scripts#216
Assignees
@muratugureminoglu @yashtandon113

Comments

@mekya
Copy link
Contributor

mekya commented Jun 19, 2023

No description provided.

@mekya mekya converted this from a draft issue Jun 19, 2023
@muratugureminoglu
Copy link
Collaborator

muratugureminoglu commented Jun 26, 2023 •
edited
Loading

If I understood correctly, it varies based on HTML tags, and there may be a situation where it doesn't work when there is a change in those pages. Please correct me if I am wrong.

Example : https://github.com/ant-media/Scripts/blob/d0fcbded688394bd83f165fe8d762c807c6ea75e/Selenium/antmedia-samples.py#L96-L100

@yashtandon113
Copy link
Contributor

@muratugureminoglu
Yes you are right.
If there will be any changes in HTML code of these sample pages then script may need to be modified accordingly. I will try to optimize it more in the upcoming days so it does not depend on the path of the element.

@muratugureminoglu
Copy link
Collaborator

@yashtandon113 We can take a look at this week together if you want.

This was linked to pull requests Jun 26, 2023
Create antmedia-samples.py ant-media/Scripts#211
Merged
samples.yml ant-media/Scripts#216
Open
@mekya mekya moved this from After sprint to 🏗 In progress in Ant Media Server Jul 10, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ant Media Server Jul 17, 2023
@muratugureminoglu
Copy link
Collaborator

Hi @yashtandon113

I merged this, but as I mentioned in the previous comment, this will likely be a problem in the future. Therefore, it would be nice to find a new solution. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muratugureminoglu muratugureminoglu

@yashtandon113 yashtandon113

Labels
None yet
Projects
Ant Media Server
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create antmedia-samples.py ant-media/Scripts
samples.yml ant-media/Scripts
3 participants
@mekya @muratugureminoglu @yashtandon113