-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated bincover with golang built-in coverage profiling tool #4962
Comments
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days |
@luolanzone @ceclinux now that we are officially using Go v1.21, we can make progress on this issue. |
Sure. |
@luolanzone @ceclinux can we move forward with this issue in order to reduce tech debt? |
I will take time to work on this, and it is expected to be finished in Antrea 1.16. Thanks. |
@luolanzone Can I give this a try? I have some experience with testing and code coverage collection. |
We have submitted this issue as a project idea for the LFX mentorship program: cncf/mentoring#1129. So no-one should ideally work on this issue until we know if the proposal is accepted and if we can match a mentee to work on it. |
Okay, thanks for the heads up. |
Hello! I'm considering applying to LFX for this project - looking forward to contribute! I'll poke around the good first issues so that I can get a better understanding of the code base before I apply to this project. Thanks! |
Hi! I am considering applying to LFX mentorship for this project. I have some experience with code coverage and testing. I would love to explore more about Antrea and its vision and goals. Thanks! |
For all the folks who have applied or are considering applying to one of the Antrea projects for the LFX mentorship program, we have published instructions to complete test tasks: #5976. We will review your submissions for these tasks alongside other material (resume, cover letter) when selecting mentees. The deadline for submitting is February 20th 5PM PST. |
Signed-off-by: Dhanush0369 <[email protected]>
This commit includes files obtained by following instructions at: antrea-io#5976 for the proposal: antrea-io#4962. The `controllerinfo.txt` file contains the ouput obtained by running the custom-built Antrea CLI binary to retrieve controller information. The `coverage.txt` file shows the fraction of statements in the `antrea.io/antrea/pkg/antctl` package executed by running: `./bin/my-antctl get controllerinfo`. Signed-off-by: VaibhavMalik4187 <[email protected]>
@shikharish will work on this as part of the LFX mentorship program |
Fixes antrea-io#4962 Signed-off-by: Shikhar Soni <[email protected]>
Fixes antrea-io#4962 Signed-off-by: Shikhar Soni <[email protected]>
Fixes antrea-io#4962 Signed-off-by: Shikhar Soni <[email protected]>
Describe what you are trying to solve
@antoninbas reported that
https://github.com/confluentinc/bincover
is deprecated:Describe the solution you have in mind
We should use built-in Go coverage profiling tool https://go.dev/testing/coverage/ to replace the deprecated one once golang 1.21 is released and Antrea is upgraded to it.
The text was updated successfully, but these errors were encountered: