Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for the NodeLatencyMonitor feature #6549

Closed
antoninbas opened this issue Jul 25, 2024 · 5 comments · Fixed by #6612
Closed

Add e2e tests for the NodeLatencyMonitor feature #6549

antoninbas opened this issue Jul 25, 2024 · 5 comments · Fixed by #6612
Labels
area/test/e2e Issues or PRs related to Antrea specific end-to-end testing. good first issue Good for newcomers kind/task Categorizes issue or PR as related to a routine task that needs to be performed

Comments

@antoninbas
Copy link
Contributor

antoninbas commented Jul 25, 2024

This is part of #5514.

The NodeLatencyMonitor feature is available (Alpha) in Antrea v2.1: #6120. However, we have no e2e tests for the feature yet.

Tests would need to cover the following:

  • feature (latency probes) can be enabled / disabled by creating / deleting the default NodeLatencyMonitor CR
  • ping interval can be changed by updating the default NodeLatencyMonitor CR
  • latency information can be retrieved using the K8s API (v1alpha1.stats.antrea.io/NodeLatencyStats)

Ideally, the e2e tests would also validate that the feature can work on Windows Nodes (not officially supported yet).

@antoninbas antoninbas added area/test/e2e Issues or PRs related to Antrea specific end-to-end testing. kind/task Categorizes issue or PR as related to a routine task that needs to be performed good first issue Good for newcomers labels Jul 25, 2024
@EraKin575
Copy link

EraKin575 commented Jul 26, 2024

I would like to work on this issue. Please assign me this issue

@antoninbas
Copy link
Contributor Author

@EraKin575 You already expressed interest in working on a different issue earlier this week. Since you are first time contributor, I suggest that you focus on a single issue at a time.
I prefer not to assign issues to first-time contributors, as it's very easy to just express interest, but in practice what happens too often is that the person doesn't follow through. Then it creates confusion as other potential contributors think the issue is already being worked on, so no one ends up working on the issue for a while and it creates unnecessary delays. If you open a PR showing that you are actively working on the issue (even if the PR is incomplete), then I will assign the issue to you to make sure that there is no duplication of effort.

@MAVRICK-1

This comment was marked as off-topic.

@antoninbas

This comment was marked as off-topic.

@Rupam-It
Copy link
Contributor

Rupam-It commented Aug 16, 2024

Hi @antoninbas , @tnqn is this issue still on? If yes then, I can work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test/e2e Issues or PRs related to Antrea specific end-to-end testing. good first issue Good for newcomers kind/task Categorizes issue or PR as related to a routine task that needs to be performed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants