Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support L4 protocol specific filters in PacketCapture #6864

Open
hangyan opened this issue Dec 13, 2024 · 2 comments
Open

Support L4 protocol specific filters in PacketCapture #6864

hangyan opened this issue Dec 13, 2024 · 2 comments
Labels
area/ops/packetcapture Issues or PRs related to the PacketCapture feature kind/feature Categorizes issue or PR as related to a new feature.

Comments

@hangyan
Copy link
Member

hangyan commented Dec 13, 2024

Describe the problem/challenge you have

Besides the protocol filter, PacketCapture should also support protocol specific filters like

  • tcp flags
  • icmp echo/reply packet
  • ...

Describe the solution you'd like

add new fields in the transportHeader section of PacketCapture spec.

Anything else you would like to add?

@hangyan hangyan added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 13, 2024
@antoninbas antoninbas added the area/ops/packetcapture Issues or PRs related to the PacketCapture feature label Dec 17, 2024
@devc007
Copy link

devc007 commented Jan 3, 2025

Hey, community!

This issue looks challenging, and I’d like to give it a try. However, I have a few questions before I proceed.

So far, my understanding of the issue is that we’re currently capturing data packets based on criteria like ports, source, destination, and possibly protocols (e.g., TCP, UDP, and ICMP). Now, the goal is to capture data packets that provide deeper insights, such as how a TCP connection is formed (e.g., the 3-way handshake involving SYN and ACK packets).

Here are my questions:

Did I understand the issue correctly?
Is the purpose of this issue to enhance monitoring capabilities?
Should I use tcpdump for this, or are there alternative methods I can consider?
Additionally, I don’t think I have enough knowledge right now to solve this effectively. I need to read and learn more, but I’m struggling to find the right documents or resources. Can you help me by suggesting some useful materials or resources?

@antoninbas
Copy link
Contributor

@devc007 Thanks for your interest. I want to emphasize that this is not a very straightforward issue: it requires API changes, correct translation of the new filters to BPF, new e2e test cases, etc. I believe this issue has the right scope for a LFX mentorship term (10-12 weeks for a new contributor), but this would not constitute a "good first issue" that can be tackled by a new contributor in a matter of hours or even days.

If you are still interested, I would recommend first experimenting with the PacketCapture feature on an actual cluster (https://github.com/antrea-io/antrea/blob/main/docs/packetcapture-guide.md), and reading the antrea-agent code that implements the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ops/packetcapture Issues or PRs related to the PacketCapture feature kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants