Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Iceberg partition identity transform #33332

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Support Iceberg partition identity transform #33332

merged 4 commits into from
Dec 27, 2024
+188 −49

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Dec 9, 2024

Fixes: #33331

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@regadas regadas force-pushed the iceberg_identity_transform branch from 35e5255 to 1d36937 Compare December 9, 2024 19:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@regadas
Copy link
Contributor Author

regadas commented Dec 9, 2024

retest this please

@regadas regadas force-pushed the iceberg_identity_transform branch from 1d36937 to 4edb2c8 Compare December 10, 2024 08:37
@regadas
Copy link
Contributor Author

regadas commented Dec 10, 2024

assign set of reviewers

@github-actions GitHub Actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions GitHub Actions
Copy link
Contributor

Reminder, please take a look at this pr: @kennknowles @shunping

@regadas
Copy link
Contributor Author

regadas commented Dec 19, 2024

@ahmedabu98 can you take a look at this one as well?

ahmedabu98
ahmedabu98 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about the avro dep

sdks/java/io/iceberg/build.gradle Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@ahmedabu98
Copy link
Contributor

waiting on author

@regadas regadas force-pushed the iceberg_identity_transform branch from 4edb2c8 to 0b075af Compare December 26, 2024 15:37
@github-actions github-actions bot added build and removed build labels Dec 26, 2024
@regadas
Copy link
Contributor Author

regadas commented Dec 26, 2024 •
edited
Loading

@ahmedabu98 addressed the comment and rebased it. Thanks for taking a look!

@github-actions github-actions bot added build and removed build labels Dec 26, 2024
@ahmedabu98 ahmedabu98 merged commit 1abc6c8 into apache:master Dec 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedabu98 ahmedabu98 ahmedabu98 approved these changes

Assignees
No one assigned
Labels
io java Next Action: Reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add support for partition identity transforms
2 participants
@regadas @ahmedabu98