Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into dropping Optional from serialized data #65

Open
keith-turner opened this issue Mar 29, 2016 · 2 comments
Open

Look into dropping Optional from serialized data #65

keith-turner opened this issue Mar 29, 2016 · 2 comments

Comments

@keith-turner
Copy link
Contributor

Optional is used in some of the Recipes APIs. It also used internally. This results in slightly larger serialized data. We could drop the use of Optional internally in classes private instance var. For example DifferenceExport.java line 49 uses Optional internally.

@jkosh44
Copy link

jkosh44 commented Oct 22, 2019

Is this still valid? The only place I see Optional being used as a field is in org.apache.fluo.recipes.core.combine.ChangeImpl and org.apache.fluo.recipes.core.map.Update.

@keith-turner
Copy link
Contributor Author

Is this still valid?

I think its stilll valid in that it would reduce data size. However looking at this now I am wondering what the impact on currently persisted data would be and how to mitigate any negative consequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants