Fix for #24 #26
Closed
Fix for #24 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String apiIdField = profile.getApiIdField(); | ||
| String apiIdValue = null; | ||
| if (apiIdField != null && !apiIdField.equals("title")) { | ||
| Map<String, Object> result = loadApiConfigFile(profile); |
There was a problem hiding this comment.
@nandoan - Can you add the entry in the apicatalog json. Its missing in the PR
| @@ -23,6 +23,7 @@ | |||
| <portal.api.doc.format>basic_html</portal.api.doc.format><!-- Format in the portal. Values: basic_html, restricted_html, full_html --> | |||
| <portal.directory>./specs</portal.directory> <!-- Directory where OpenAPI specs are accessible. Using ./specs for sample --> | |||
| <apigee.smartdocs.config.file>./apicatalog-config.json</apigee.smartdocs.config.file> <!-- Config for fields --> | |||
| <portal.api.id.field>title</portal.api.id.field> | |||
There was a problem hiding this comment.
@nandoan - Why do I need this entry in the pom file? Why not just get the entry from apicatalog json as you are looking for "title" anyways?
| logger.info("Getting API doc for "+ spec.getTitle()); | ||
| String apiIdField = profile.getApiIdField(); | ||
| String apiIdValue = null; | ||
| if (apiIdField != null && !apiIdField.equals("title")) { |
There was a problem hiding this comment.
@nandoan - not sure I prefer the title check being hardcoded, then it doesnt make sense to have this in the pom as a property. The ideal thing would be to just look for the title field in the apicatalog json or else get the value from the pom and see if that matches any key in the apicatalog json and use that value in the code.
|
Closing this.. Please reopen if you take care of the comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new optional property to configure the API Identification field, as described in #24.