-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading vega-lite version #6
Comments
These patches are needed because some parts of Vega are hardcoded to work differently between Node and the browser, but Darkstar is neither of those and needs some functionality from each (network and filesystem resource fetching). If you want to have a good at doing the upgrade yourself, the best way would be to diff the original |
I've done this and it seems to be working. But it will require some more testing, though, honestly there shouldn't be much more to it. Will keep you updated. |
@jackrusher - The tests have a dependency on |
Sorry, busy few days. I must have been testing with an older JVM. Why not add it to the test section of the |
Both Vega and Vega lite have had significant version releases this past year.
In order to upgrade, I should ideally be able to fork your repo, stick in the new .js files and get them to work. However, I see you've patched a polyfill on vega.js(though not on vega lite, understandably). So what upgrade path would you recommend?
The text was updated successfully, but these errors were encountered: