Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading vega-lite version #6

Open
craftybones opened this issue Apr 14, 2021 · 4 comments
Open

Upgrading vega-lite version #6

craftybones opened this issue Apr 14, 2021 · 4 comments

Comments

@craftybones
Copy link

Both Vega and Vega lite have had significant version releases this past year.

In order to upgrade, I should ideally be able to fork your repo, stick in the new .js files and get them to work. However, I see you've patched a polyfill on vega.js(though not on vega lite, understandably). So what upgrade path would you recommend?

@jackrusher
Copy link
Member

These patches are needed because some parts of Vega are hardcoded to work differently between Node and the browser, but Darkstar is neither of those and needs some functionality from each (network and filesystem resource fetching). If you want to have a good at doing the upgrade yourself, the best way would be to diff the original vega.js against my patched version and then try to introduce the same modifications to the new version.

@craftybones craftybones changed the title Upgrading vega-ilte version Upgrading vega-lite version Apr 14, 2021
@craftybones
Copy link
Author

I've done this and it seems to be working. But it will require some more testing, though, honestly there shouldn't be much more to it. Will keep you updated.

@craftybones
Copy link
Author

@jackrusher - The tests have a dependency on javax.xml.bind.DatatypeConverter which seems to have been one of the packages removed from the JDK after Java 9. Are you running them on an older version or are you adding the modules on the classpath at runtime? If so, shouldn't that be in deps.edn ?

@jackrusher
Copy link
Member

Sorry, busy few days. I must have been testing with an older JVM. Why not add it to the test section of the deps.edn and give it a go on a newer JVM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants