Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Scanner page's upload button shows incorrect error #280

Open
pohuing opened this issue Oct 12, 2023 · 0 comments · May be fixed by #281
Open

[Bug]: Scanner page's upload button shows incorrect error #280

pohuing opened this issue Oct 12, 2023 · 0 comments · May be fixed by #281
Assignees
Labels
bug Something isn't working

Comments

@pohuing
Copy link

pohuing commented Oct 12, 2023

What happened?

Paperless mobile shows an incorrect error message in the scanner page.

Steps to reproduce

  1. Open scanner page
  2. Tap upload in top bar, make sure no documents have been scanned yet
  3. See error indicating missing internet connection

Log output from the app

No response

Screenshots

image

Paperless-ng*x Version

1.16.5

Paperless-Mobile Version

3.0.1+1048

Device

Google Pixel 4a

Operating System Version

Android 13

Device Locale

German, English

Selected Locale

German

Additional Context

The issue is the use of the ConnectivityAwareActionWrapper in scanner_page line 144.
ConnectivityAwareActionWrapper always displays the offline message, even if the action is disabled through the disabled parameter (which is the case in this bug) [link to code].

I don't know if adding a disabled reason to show in the snackbar would be sensible, or to just not show a message at all, the other actions don't show an error message either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

2 participants