Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons not loading #3568

Open
4 of 11 tasks
yshmarov opened this issue Jan 3, 2025 · 2 comments
Open
4 of 11 tasks

Icons not loading #3568

yshmarov opened this issue Jan 3, 2025 · 2 comments
Labels
Waiting on Reproduction Pending reproduction repository or detailed reproduction steps to proceed with issue resolution.

Comments

@yshmarov
Copy link
Contributor

yshmarov commented Jan 3, 2025

Describe the bug

Reproduction repository for the bug

System configuration

Avo version:
3.15.7
Rails version:
7.1.3.4
Ruby version:
3.3.3
License type:

  • Community
  • Pro
  • Advanced

Are you using Avo monkey patches, overriding views or view components?

  • Yes. If so, please post code samples.
  • No

Screenshots or screen recordings

Image

Additional context

Impact

  • High impact (It makes my app un-usable.)
  • Medium impact (I'm annoyed, but I'll live.)
  • Low impact (It's really a tiny thing that I could live with.)

Urgency

  • High urgency (I can't continue development without it.)
  • Medium urgency (I found a workaround, but I'd love to have it fixed.)
  • Low urgency (It can wait. I just wanted you to know about it.)
@Paul-Bob
Copy link
Contributor

Paul-Bob commented Jan 6, 2025

Hi @yshmarov

https://main.avodemo.com/ is running on Avo 3.15.7 and is loading icons as expected, could you please include a reproduction repository?

@Paul-Bob Paul-Bob added the Waiting on Reproduction Pending reproduction repository or detailed reproduction steps to proceed with issue resolution. label Jan 6, 2025
@adrianthedev
Copy link
Collaborator

This looks like something that the parent app causes. A few things come to mind:

  1. Check the DOM in those places where the SVGs are missing. They should say something like "SVG not found THE_NAME_OF_THE_SVG". We'd love to see what that says.
  2. Does the app have an svg helper? that might override Avo's helper
  3. Is it a new or existing app? I would guess an existing one.
  4. Does that happen in which environment? Dev, prod., both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting on Reproduction Pending reproduction repository or detailed reproduction steps to proceed with issue resolution.
Projects
Status: No status
Development

No branches or pull requests

3 participants