use protobuf content type instead of json for k8s client #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
bhavi-koduru
force-pushed
the
use-protobuf
branch
from
59fd9fb to
e2703c7
Compare
bhavi-koduru
force-pushed
the
use-protobuf
branch
from
e2703c7 to
4cf8572
Compare
hakuna-matatah
approved these changes
Sep 24, 2024
|
Apparently api server does not fall back if type does not support CRD. Here is issue in k/k kubernetes/kubernetes#86253. |
|
I believe the network policy controller e2e covers CRD creation as well which were passing after the latest commit. In the previous commit, the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
This MR is a part of effort to elevate single eks cluster performance by migrating the EKS components to use protobuf instead of json.
Modify kubeconfig type to use content type application/vnd.kubernetes.protobuf instead of json for performance gain.
If an issue # is not available please add steps to reproduce and the controller logs:
Testing done on this change:
Automation added to e2e:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.